Skip to content

Comments

fix: remove duplicate CI pipeline on push to main#12

Merged
AndrewAltimit merged 1 commit intomainfrom
fix/remove-duplicate-ci-pipeline
Feb 21, 2026
Merged

fix: remove duplicate CI pipeline on push to main#12
AndrewAltimit merged 1 commit intomainfrom
fix/remove-duplicate-ci-pipeline

Conversation

@AndrewAltimit
Copy link
Owner

@AndrewAltimit AndrewAltimit commented Feb 21, 2026

Summary

  • Deleted .github/workflows/ci.yml -- this workflow triggered on push: branches: [main] with the exact same CI steps as main-ci.yml, causing every merge to main to run the full CI suite twice
  • Updated CLAUDE.md to reflect the remaining two workflows instead of three
  • main-ci.yml already handles all CI checks (fmt, clippy, test, build, deny, emulator) plus release binary creation and GitHub Release on tags/manual trigger -- ci.yml was entirely redundant

Test plan

  • Verify main-ci.yml still runs on push to main (triggers section unchanged)
  • Verify pr-validation.yml still runs on PR open/sync/reopen (untouched)
  • Confirm only 1 pipeline fires on merge to main, not 2

Generated with Claude Code

@claude
fix: remove duplicate CI pipeline that ran on every push to main
b05f820 
ci.yml and main-ci.yml both triggered on push to main with identical
CI steps, causing every merge to run the full suite twice. main-ci.yml
already covers all CI checks plus release handling, making ci.yml
entirely redundant.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Feb 21, 2026

Gemini AI Code Review

Issues (if any)

(none)

Previous Issues (for incremental reviews)

(none)

Suggestions (if any)

(none)

Notes

  • 2 claim(s) were automatically filtered as potential hallucinations (file:line content didn't match claims)

  • The deletion of .github/workflows/ci.yml correctly removes redundant CI execution on the main branch.

  • main-ci.yml contains all essential steps (formatting, linting, testing, building, and emulator tests) previously in ci.yml.

  • main-ci.yml is correctly configured to trigger on push to main and includes additional logic for release binary creation and automated GitHub Releases on tags.

  • CLAUDE.md documentation has been appropriately updated to reflect the simplified workflow structure.

  • pr-validation.yml remains untouched and continues to provide comprehensive CI and AI-driven review coverage for pull requests.

Reaction

Generated by Gemini AI (gemini-3-flash-preview). Supplementary to human reviews.

@github-actions
Copy link

github-actions bot commented Feb 21, 2026

Codex AI Code Review

Issues (if any)

(none)

Previous Issues (for incremental reviews)

(none)

Suggestions (if any)

(none)

Notes

  • 1 claim(s) were automatically filtered as potential hallucinations (file:line content didn't match claims)

  • Verified deleting .github/workflows/ci.yml leaves one push CI pipeline for main via .github/workflows/main-ci.yml.

  • Verified .github/workflows/main-ci.yml still triggers on push to main, tags: v*, and workflow_dispatch; pr-validation.yml [UNVERIFIED - File does not exist and is not in PR] remains unchanged for PR events.

  • Verified documentation update is consistent: CLAUDE.md:121 now accurately lists two workflows.

Reaction

Generated by Codex AI (gpt-5.3-codex). Supplementary to human reviews.

@AndrewAltimit
Copy link
Owner Author

AndrewAltimit commented Feb 21, 2026

Review Response Agent (Iteration 1)

Status: No changes needed

Fixed Issues

  • (none — both reviews reported zero issues)

Ignored Issues

  • (none — no issues were raised)

Deferred to Human

  • (none)

Notes

  • Both Gemini and Codex reviews approved PR fix: remove duplicate CI pipeline on push to main #12 with no issues and no suggestions
  • Gemini had 2 auto-filtered hallucinated claims; Codex had 1 — none made it into the final reviews
  • The PR correctly removes the duplicate ci.yml workflow and updates CLAUDE.md documentation

The agent reviewed feedback but determined no code changes were required.

@AndrewAltimit AndrewAltimit merged commit 4c47345 into main Feb 21, 2026
7 checks passed
@AndrewAltimit AndrewAltimit deleted the fix/remove-duplicate-ci-pipeline branch February 21, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AndrewAltimit